[oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

Trevor Woerner twoerner at gmail.com
Sat May 26 02:45:24 UTC 2018


On Fri, May 25, 2018 at 3:58 PM, Andre McCurdy <armccurdy at gmail.com> wrote:

> On Fri, May 25, 2018 at 8:22 AM, Trevor Woerner <twoerner at gmail.com>
> wrote:
> > As Anuj pointed out with patch 16/17 of this series (opencv: rely on
> > cmake.bbclass...), so too is this patch wrong and shouldn't be applied.
> > Sorry!
> >
> > Looking closer at this recipe (on an unrelated issue) do we really want
> the
> > include files being part of FILES_${PN}?
>
> No, we don't. It looks like it's been done that way as a workaround
> for the libeigen build not creating anything which would normally go
> in the main package. Setting:
>
>   ALLOW_EMPTY_${PN} = "1"
>
> together with careful review of the packaging rules and probably
> removing the RDEPENDS and RRECOMMENDS over-rides may be a better
> solution.
>
> You should also carefully check that things work as expected when
> libeigen is added to an SDK. That's a corner case which tests
> dependencies between runtime and -dev packages which isn't tested
> during a normal build (for what it's worth, creating an empty runtime
> package by using ALLOW_EMPTY_${PN} = "1" has always been the easiest
> solution whenever I've looked into this kind of issue in the past and
> it "just works" for the SDK case).
>

Sounds good; I'll take a look. Thanks!



More information about the Openembedded-devel mailing list