[oe] [meta-oe][rocko][PATCH v2] protobuf: fix SRC_URI by removing branch

[George McCollister]

On Wed, May 30, 2018 at 10:15 AM, Khem Raj <raj.khem at gmail.com> wrote:
> Can you try this patch with
>
> Bitbake -cleanall recipe
>
> And bake it again

bitbake -c cleanall protobuf
bitbake protobuf

Works fine for me with the patch applied. Did you run into a problem
or have a concern?

>
> On Wed, May 30, 2018 at 6:48 AM George McCollister
> <george.mccollister at gmail.com> wrote:
>>
>> The 3.4.x branch was removed upstream but the commit referenced in
>> SRC_REV is the 3.4.1 release and is still available:
>> https://github.com/google/protobuf/releases/tag/v3.4.1
>>
>> Drop branch=3.4.x from SRC_URI and use commit specified in SRC_REV from
>> the master branch.
>>
>> Signed-off-by: George McCollister <george.mccollister at gmail.com>
>> ---
>>
>> v2:
>>  - Correct commit message.
>>
>>  meta-oe/recipes-devtools/protobuf/protobuf_3.4.1.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.4.1.bb
>> b/meta-oe/recipes-devtools/protobuf/protobuf_3.4.1.bb
>> index fae7c18a1..fe28f475a 100644
>> --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.4.1.bb
>> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.4.1.bb
>> @@ -18,7 +18,7 @@ SRCREV = "b04e5cba356212e4e8c66c61bbe0c3a20537c5b9"
>>
>>  PV = "3.4.1+git${SRCPV}"
>>
>> -SRC_URI = "git://github.com/google/protobuf.git;branch=3.4.x"
>> +SRC_URI = "git://github.com/google/protobuf.git"
>>
>>  EXTRA_OECONF += " --with-protoc=echo"
>>
>> --
>> 2.11.0
>>
>